Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetCategoryChannel method #1261

Merged
merged 1 commit into from
May 4, 2019
Merged

Add GetCategoryChannel method #1261

merged 1 commit into from
May 4, 2019

Conversation

Still34
Copy link
Member

@Still34 Still34 commented Feb 8, 2019

No description provided.

@Still34 Still34 changed the title Add GetCategory method Add GetCategoryChannel method Feb 8, 2019
Chris-Johnston
Chris-Johnston approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@Chris-Johnston Chris-Johnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of just "if none is found" we could also explain null is returned if the channel id is not a category channel.

Otherwise lgtm

@bloodwiing
Copy link

bloodwiing commented Apr 6, 2019 •
edited
Loading

So... Is a merge happening anytime?
I've built the WebSocket library from Still34's forked repo and am using that, but would still like to use the Nuget one. 🙂
I'd need to rewrite everything to make that work. So will wait for this...

@foxbot foxbot merged commit e03c527 into discord-net:dev May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chris-Johnston Chris-Johnston Chris-Johnston approved these changes

@foxbot foxbot foxbot approved these changes

Assignees
No one assigned
Labels
priority: improvement project: websocket version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Still34 @bloodwiing @foxbot @Chris-Johnston